From f5ade5cb53dd48d2b5bbb6afd07e204a0ed0f50a Mon Sep 17 00:00:00 2001
From: HotelSync <admin@hotelsync.ru>
Date: Thu, 19 Mar 2026 12:34:54 +0300
Subject: [PATCH] Fix: reservation_id must be string not number (NetUP API)

---
 backend/src/routes/netup.ts | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/backend/src/routes/netup.ts b/backend/src/routes/netup.ts
index e611b38..0090e8a 100644
--- a/backend/src/routes/netup.ts
+++ b/backend/src/routes/netup.ts
@@ -318,7 +318,7 @@ const netup: FastifyPluginAsync = async (fastify) => {
       if (!room) return reply.code(404).send({ error: 'Room not found' })
 
       const result = await notifyNetupCheckinInternal(
-        hotelId, room_id, room.number, 'Тестовый гость', 'test-' + Date.now(),
+        hotelId, room_id, room.number, 'Тестовый гость', 'TEST-' + room.number,
       )
       if (result.ok) return { ok: true, message: `Check-in отправлен в NetUP (номер ${result.netupRoom})` }
       return reply.code(502).send({ error: result.error ?? 'Ошибка' })
@@ -368,9 +368,8 @@ async function notifyNetupCheckinInternal(
   const url  = `${base}/mw/api/hotel-room/${encodeURIComponent(mapping.netup_room_number)}/check-in`
   const cred = Buffer.from(`${cfg.username}:${cfg.password}`).toString('base64')
 
-  // reservation_id must be a number in NetUP — convert UUID/string to integer
-  const resIdNum = parseInt(reservationId.replace(/\D/g, '').slice(-8), 10) || Date.now() % 1000000
-  const requestBody = { reservation_id: resIdNum, name: guestName, language: language ?? cfg.default_language }
+  // NetUP expects reservation_id as a string
+  const requestBody = { reservation_id: reservationId, name: guestName, language: language ?? cfg.default_language }
 
   try {
     const res = await fetch(url, {